-
-
Notifications
You must be signed in to change notification settings - Fork 214
[Firecms] Add support for typesense search #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on how Camberi are deploying and what their CI/CD looks like, yarn.lock might actually need to be committed to the repo so I'm not sure that this change will be accepted if you mess with that 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is correct, yarn.lock should not be excluded from Git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move this dependency to peer dependencies?
So that only users who want to use it can pull it in.
Thanks!
mvarchdev
commented
Sep 20, 2023
@yash1200 Hello! Is this ready to merge?
This PR adds supports for typesense search and also add
yarn.lockfile to gitignore.