Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Rearranging include and using statements #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

@Grant-Postma
Copy link

@Grant-Postma Grant-Postma commented Jul 8, 2020

No description provided.

Grant-Postma and others added 8 commits June 26, 2020 12:51
* Moving common functions into header files.
Moving database & auth to MainMenuScene.
Adding Auth node with fields and listeners.
Set up user record management.
Set up user sign-up, login and anonymous login.
* auth full review by @DellaBitta
* Private Class variables.
Bug on disbanded room.
* Moving common functions to util.h and util.cpp.
Adding more comments on util functions.
* Added missing period.
* removing double new line.
modifying includes in util.h and util.cpp
* Moving common functions to util.h and util.cpp.
Adding more comments on util functions.
* Added missing period.
* removing double new line.
modifying includes in util.h and util.cpp
* refactor file names
* reverting cmake unnessecary changes.
* Update for API changes
* Change logging from verbose to warning
Otherwise test results get lost in the crowd.
* Add spaces around equals signs
* Integrate Latest @ 314842997
CL: 314842997
* refactor file names
* Adding util.cpp and util.h files (firebase#54)
* Auth full changes (#8)
* Moving common functions into header files.
Moving database & auth to MainMenuScene.
Adding Auth node with fields and listeners.
Set up user record management.
Set up user sign-up, login and anonymous login.
* auth full review by @DellaBitta
* Private Class variables.
Bug on disbanded room.
* Moving common functions to util.h and util.cpp.
Adding more comments on util functions.
* Added missing period.
* removing double new line.
modifying includes in util.h and util.cpp
* reverting cmake unnessecary changes.
* deleteing util.cpp.
* Removing old include header.
Co-authored-by: Mark Grimes <kknb1056@gmail.com>
Co-authored-by: Morgan Chen <morganchen12@gmail.com>
Co-authored-by: Anthony <amaurice@google.com>
Co-authored-by: Alex Ames <amablue@google.com>
Duplicate libaray statements replaced with using statement.
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

i️ Googlers: Go here for more info.

@Grant-Postma Grant-Postma deleted the rearranging-include-and-using-statements branch August 6, 2020 18:43
@firebase firebase locked and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /