-
Notifications
You must be signed in to change notification settings - Fork 135
trimming unused include statements; adding using statements #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Moving common functions into header files. Moving database & auth to MainMenuScene. Adding Auth node with fields and listeners. Set up user record management. Set up user sign-up, login and anonymous login. * auth full review by @DellaBitta * Private Class variables. Bug on disbanded room.
* Moving common functions to util.h and util.cpp. Adding more comments on util functions. * Added missing period. * removing double new line. modifying includes in util.h and util.cpp
* Moving common functions to util.h and util.cpp. Adding more comments on util functions. * Added missing period. * removing double new line. modifying includes in util.h and util.cpp
* refactor file names * reverting cmake unnessecary changes.
* Update for API changes * Change logging from verbose to warning Otherwise test results get lost in the crowd. * Add spaces around equals signs * Integrate Latest @ 314842997 CL: 314842997 * refactor file names * Adding util.cpp and util.h files (firebase#54) * Auth full changes (#8) * Moving common functions into header files. Moving database & auth to MainMenuScene. Adding Auth node with fields and listeners. Set up user record management. Set up user sign-up, login and anonymous login. * auth full review by @DellaBitta * Private Class variables. Bug on disbanded room. * Moving common functions to util.h and util.cpp. Adding more comments on util functions. * Added missing period. * removing double new line. modifying includes in util.h and util.cpp * reverting cmake unnessecary changes. * deleteing util.cpp. * Removing old include header. Co-authored-by: Mark Grimes <kknb1056@gmail.com> Co-authored-by: Morgan Chen <morganchen12@gmail.com> Co-authored-by: Anthony <amaurice@google.com> Co-authored-by: Alex Ames <amablue@google.com>
Duplicate libaray statements replaced with using statement.
googlebot
commented
Jul 8, 2020
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.
In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.
i️ Googlers: Go here for more info.
As a developer, I want to clean up the unnecessary include statements and add using statements for repeated imported class code, so that the include statements only have what is essential in that document and it will cut down on the verbosity of the class imported code.