-
Couldn't load subscription status.
- Fork 135
Add CI Android targets #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this file to this Android-only build PR because build_testapps.py refers to it and I thought it would be better to submit it now and alter it later than to prune build_testapps.py of all xcode references only to add them back in later.
It seems safer this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File is mainly a directly copy of the one from the C++ SDK repo. Mainly changes have been made to the paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly a direct copy of the C++ SDK version, with the removal of all of the vcpkg functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly a direct copy of the Firebase C++ SDK version, but the comments which contain the example have been updated with the test app bundle ids / naming convention.
@sunmou99
sunmou99
left a comment
•
edited
Loading
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Because the build scripts are almost identical to the scripts in C++ repo, it maybe better to create a github action which handles environment setting steps and the build steps in the future.
Yes, I was thinking along the same lines!
Uh oh!
There was an error while loading. Please reload this page.
Adds a CI Workflow to build the testapps against the publicly available packaged SDK.