Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix(remote config, web): More explicit interop types #17814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MichaelVerdon wants to merge 2 commits into main
base: main
Choose a base branch
Loading
from remote-config-interop
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,19 @@ external JSPromise<JSBoolean> activate(RemoteConfigJsImpl remoteConfig);

@JS()
@staticInterop
external JSPromise ensureInitialized(RemoteConfigJsImpl remoteConfig);
external JSPromise<JSBoolean> ensureInitialized(RemoteConfigJsImpl remoteConfig);

@JS()
@staticInterop
external JSPromise<JSBoolean> fetchAndActivate(RemoteConfigJsImpl remoteConfig);

@JS()
@staticInterop
external JSPromise fetchConfig(RemoteConfigJsImpl remoteConfig);
external JSPromise<JSBoolean> fetchConfig(RemoteConfigJsImpl remoteConfig);

@JS()
@staticInterop
external JSAny getAll(RemoteConfigJsImpl remoteConfig);
external JSObject getAll(RemoteConfigJsImpl remoteConfig);

@JS()
@staticInterop
Expand All @@ -53,7 +53,7 @@ external ValueJsImpl getValue(RemoteConfigJsImpl remoteConfig, JSString key);

@JS()
@staticInterop
external JSPromise isSupported();
external JSPromise<JSBoolean> isSupported();

@JS()
@staticInterop
Expand All @@ -66,11 +66,7 @@ external JSPromise setCustomSignals(
@staticInterop
external void setLogLevel(RemoteConfigJsImpl remoteConfig, JSString logLevel);

@JS('RemoteConfig')
@staticInterop
abstract class RemoteConfigJsImpl {}

extension RemoteConfigJsImplExtension on RemoteConfigJsImpl {
extension type RemoteConfigJsImpl._(JSObject _) implements JSObject {
external AppJsImpl get app;
external SettingsJsImpl get settings;
external set settings(SettingsJsImpl value);
Expand All @@ -80,24 +76,15 @@ extension RemoteConfigJsImplExtension on RemoteConfigJsImpl {
external JSString get lastFetchStatus;
}

@JS()
@staticInterop
@anonymous
abstract class ValueJsImpl {}

extension ValueJsImplExtension on ValueJsImpl {
extension type ValueJsImpl._(JSObject _) implements JSObject {
external JSBoolean asBoolean();
external JSNumber asNumber();
external JSString asString();
external JSString getSource();
}

@JS()
@staticInterop
@anonymous
abstract class SettingsJsImpl {}

extension SettingsJsImplExtension on SettingsJsImpl {
extension type SettingsJsImpl._(JSObject _) implements JSObject {
external JSNumber get minimumFetchIntervalMillis;
external set minimumFetchIntervalMillis(JSNumber value);
external JSNumber get fetchTimeoutMillis;
Expand All @@ -121,12 +108,7 @@ extension ConfigUpdateObserverJsImpl on ConfigUpdateObserver {
external JSAny get complete;
}

@JS()
@staticInterop
@anonymous
abstract class ConfigUpdateJsImpl {}

extension ConfigUpdateJsImplExtension on ConfigUpdateJsImpl {
extension type ConfigUpdateJsImpl._(JSObject _) implements JSObject {
external JSSet getUpdatedKeys();
}

Expand Down
Loading

AltStyle によって変換されたページ (->オリジナル) /