fix(firebase_messaging): fix null apple notification when sound is of type String #17770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Lyokone merged 1 commit into firebase:main from abdalin:fix/apple-notification-sound

Oct 9, 2025

Merged

fix(firebase_messaging): fix null apple notification when sound is of type String #17770

Lyokone merged 1 commit into firebase:main from abdalin:fix/apple-notification-sound

Oct 9, 2025

+1 −1

Conversation

@abdalin

Copy link

Contributor

@abdalin abdalin commented Oct 6, 2025

fixed notification sound being null in notification.apple.sound of onMessage stream

Description

If a notification is sent from backend with a sound file String, the sound value in RemoteMessage.notification.apple.sound is being received as null in FirebaseMessaging.onMessage stream of Flutter interface. That was because sound was incorrectly being assigned to notification instead of notificationIOS in FLTFirebaseMessagingPlugin implementation of iOS.

Related Issues

None

Checklist

[ x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[ x] All existing and new tests are passing.
[ x] I updated/added relevant documentation (doc comments with ///).
[ x] The analyzer (melos run analyze) does not report any problems on my PR.
[ x] I read and followed the Flutter Style Guide.
[ x] I signed the CLA.
[ x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change.
[x ] No, this is not a breaking change.

@abdalin


 fix(firebase_messaging): fix null apple notification when sound is of...

470e923

... type String

@gemini-code-assist

Copy link

gemini-code-assist bot commented Oct 6, 2025

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.