-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Added NS_ERROR_ENUM to Firebase Auth, breaking changes (#7723) #9000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ryanwilson
merged 2 commits into
firebase:v9b
from
a-25:firebase-auth-ns-error-enum-support
Mar 31, 2022
Merged
Added NS_ERROR_ENUM to Firebase Auth, breaking changes (#7723) #9000
ryanwilson
merged 2 commits into
firebase:v9b
from
a-25:firebase-auth-ns-error-enum-support
Mar 31, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@a-25
a-25
changed the title
(削除) [WIP] Added NS_ERROR_ENUM to Firebase Auth, breaking changes (#7723) (削除ここまで)
(追記) Added NS_ERROR_ENUM to Firebase Auth, breaking changes (#7723) (追記ここまで)
Dec 6, 2021
Thanks for the contribution - this is now going through API review. #9512 covers the rest of the API surface to move at the moment.
cc @rosalyntan for the code that's associated with the API review.
Changed the base to the V9 branch where this will be released - merging now. Thanks for the contribution!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Possible fix for issue (#7723) FR: Support NS_ERROR_ENUM for better error handling in Swift
Breaking changes
Note from @ryanwilson: this is a one line change with 347 lines of formatting changes.