Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

rCE Unit Tests #13547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pragatimodi wants to merge 6 commits into phone-auth-login
base: phone-auth-login
Choose a base branch
Loading
from rce-phone-tests
Open

rCE Unit Tests #13547

pragatimodi wants to merge 6 commits into phone-auth-login from rce-phone-tests

Conversation

@pragatimodi
Copy link
Contributor

@pragatimodi pragatimodi commented Aug 27, 2024 •
edited
Loading

Recaptcha Enterprise Unit Testing

  • Enforce: Success
  • Enforce: Invalid Token
  • Enforce: recaptchaSDKNotLinked
  • Enforce: actionCreationFailed

Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@pragatimodi pragatimodi changed the base branch from phone-auth-login to main September 3, 2024 23:44
@pragatimodi pragatimodi changed the base branch from main to phone-auth-login September 3, 2024 23:45 
author Pragati <pragatimodi@google.com> 1724775429 -0700
committer Pragati <pragatimodi@google.com> 1725423960 -0700
Unit Tests
drafted tests
adding mock rce enforce test
remove wip test
add error cases
lint changes
line
fix CI failures
modifying objc methods to use swift implementations
remove ios only enablement enum
address PR feedback
adding mock rce enforce test
lint changes
modifying objc methods to use swift implementations
remove ios only enablement enum
add/remove rebasing changes
@pragatimodi pragatimodi changed the title (削除) Unit Tests (削除ここまで) (追記) rCE Unit Tests (追記ここまで) Sep 4, 2024
Copy link
Contributor

@Xiaoshouzi-gh Xiaoshouzi-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for adding this!

uiDelegate: nil,
recaptchaVerifier: mockVerifier
)
// XCTAssertEqual(result, kTestVerificationID)
Copy link

@Sambit650 Sambit650 Sep 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very minor: we can remove this commented line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulb777 paulb777 paulb777 approved these changes

@Xiaoshouzi-gh Xiaoshouzi-gh Xiaoshouzi-gh approved these changes

+1 more reviewer

@Sambit650 Sambit650 Sambit650 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /