-
Notifications
You must be signed in to change notification settings - Fork 269
feat: Parse screenName in ProvidedUserInfo #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Parse screenName in ProvidedUserInfo #611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sixstone-qq ! LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting my review till we get approval from @pragatimodi
5da2b98 to
8a82f96
Compare
502f91e to
b77aea8
Compare
@pragatimodi it would be great if you can take a look on it to merge it upstream? Thanks a lot for your help here.
@lahirumaramba would this need an API council approval? or do we have an approved proposal for this already?
66aaf2b to
e76b863
Compare
Any update on this?
This is available when having multiple providers where it provides a screen name such as Twitter or GitHub. See https://cloud.google.com/identity-platform/docs/reference/rest/v1/ProviderUserInfo for details. It's available at endpoints like accounts.lookup or projects.queryAccounts Signed-off-by: Enrique J. Hernández <sixstone-qq@users.noreply.github.com>
e76b863 to
53f88a6
Compare
Discussion
It tries to fix #610 .
Testing
Adapt existing mocked data.
API Changes
Adding a new public field to UserInfo only populated under ProvidedUserInfo that is available in public API