Please don't bump the version in a PR. This should happen when the new version is actually published.

sure

Why was this test removed? What happens when an invalid argument like an object is passed in?

Response is able to accept many things, Typed arrays, ArrayBuffer, strings, Blob/files, FormData, URLSearchParams, ReadableStream, and even DataView and convert it to a ArrayBuffer using new Response(x).arrayBuffer()

It would be silly to just restrict it to only Blobs when you can accept many more types of stuff and let it be more loose and be used for more than just Blobs.

anything not understood by the Response constructor will be casted to a string using the toString function or secondly String(x)

so what happens when you do

• await new Response({}).text() is that you get "[object Object]"
• await new Response(new Date()).text() yields "Sat Aug 24 2019 00:33:59 GMT+0200 (centraleuropeisk sommartid)" (since it has a toSting function)
• await new Response({toString() { return 'abc'}}).text() yields "abc" even doe it's a plain object

So it's a bit hard to get a error when Response can accept literally anything

So it's no longer just blob-to-buffer, it's now anything to buffer

I would prefer this function to be named so it shows up with a name in stack traces. Also, I know that Response can handle many types, but the point of this package is to convert a blob, so the argument should be called blob.

ok

Can we keep this check in, but reverse the condition? It would be nice to help folks who are upgrading from 1.x and might leave the callback in by accident? It's similar to how we left the check in stream-to-blob when switching to promises: https://github.com/feross/stream-to-blob/blob/34d257b46d0f8c5d710194336d87f0623aa60fd4/index.js#L7

mm, don't follow... 😕

maybe close this PR just and let you do as you want?

Can you switch this example to use await?

sure, i only used .then() as it was more cross platform compatible and many ppl just copy/paste code without using babel

Buffer.from won't work in a browser?