-
Couldn't load subscription status.
- Fork 187
Complete class aliases whose targets do not exist #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Declspeck
wants to merge
40
commits into
felixfbecker:master
from
Declspeck:autocomplete-add-non-existent-use-class
Open
Complete class aliases whose targets do not exist #605
Declspeck
wants to merge
40
commits into
felixfbecker:master
from
Declspeck:autocomplete-add-non-existent-use-class
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 48bbbb5.
Codecov Report
@@ Coverage Diff @@ ## master #605 +/- ## ============================================ + Coverage 81.63% 81.98% +0.34% - Complexity 910 947 +37 ============================================ Files 61 61 Lines 2075 2231 +156 ============================================ + Hits 1694 1829 +135 - Misses 381 402 +21
|
This was referenced Feb 24, 2018
Is this still relevant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support and a test for the following case:
This is primarily useful in cases where the target class is not indexed for some reason.
This PR is based on #599 so it cannot be merged before that and only the last commit f5b1256 contains new changes.