-
Couldn't load subscription status.
- Fork 7
Fix "TS2304: Cannot find name 'ToastType'." error in TS definitions + make message optional when updating #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coveralls
commented
Nov 13, 2018
Pull Request Test Coverage Report for Build 15
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
screen shot 2018年11月13日 at 11 27 26
The current Typescript definitions throw a TS2304 error, because the
ToastTypeimport being used here (imported from the react-toastify package) is an interface, not a type definition - https://github.com/fkhadra/react-toastify/blob/master/index.d.ts#L299.The type definition that needs to be matched against is actually
TypeOptions- https://github.com/fkhadra/react-toastify/blob/master/index.d.ts#L70 - however this is not exported.Seeing as a load of other types are being manually defined in the react-toastify-redux definitions file (eg.
pauseOnHover,hideProgressBar) I think it makes sense to just manually define the types locally, until the core package exports the necessary types.I've also changed the message option to be optional on the
update()method definition; it's not required in the core package, as you may only want to update another option such as type.