-
-
Notifications
You must be signed in to change notification settings - Fork 784
✨ Add IntEnum type that allows storing values of enum as integers in database
#1337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...nto feat/IntEnum
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Motov Yurii <109919500+YuriiMotov@users.noreply.github.com>
Updates the `IntEnum` SQLAlchemy type to `SmallInteger`. This change reduces the storage size required for `IntEnum` columns when the full range of `Integer` is not needed.
Adds tests to ensure that integer enum fields are correctly handled in both Postgres and SQLite DDL generation.
@KunxiSun, thanks for your interest and efforts!
I think this feature is quite useful. There seems to be no simple solution to configure int enums this way without creating custom
TypeDecorator. This PR will provide such solution.Please take a look at my in-code comments. Also, we need to update these tests to check statements for new field
Thanks for your code suggestion.
The statement tests are added.
I also changed the type from Integer to Small Integer, cuz I think the size of Integer is too large to be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks interesting!
I think this feature is quite useful.
There seems to be no simple solution to configure int enums this way without creating custom TypeDecorator. This PR will provide such solution.
Implementation and tests look good to me.
We may want to describe this in docs, but maybe it's better to wait for Sebastian to validate the idea first
IntEnum type that allows storing values of enum as integers in database (追記ここまで)
Uh oh!
There was an error while loading. Please reload this page.
I add a IntEnum type decorator which I used in my private project.
I wish it helps!