-
-
Couldn't load subscription status.
- Fork 782
🐛 Make generics work with SQLModel as base class #1275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+89
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(削除) (I broke the pydantic v1 tests because I added a test and forgot to label it as v2 only. I will fix it when I get back to my computer.) (削除ここまで)
Fixed. Once #1276 is merged, all this PR's tests should pass.
@svlandeg
svlandeg
added
bug
Something isn't working
and removed
feature
New feature or request
labels
Feb 20, 2025
@svlandeg
svlandeg
changed the title
(削除) fix: make generics work with SQLModel as base class (削除ここまで)
(追記) 🐛 Make generics work with SQLModel as base class (追記ここまで)
Feb 20, 2025
Thanks for the contribution! We're currently trying to catch up with the backlog of PRs, and will get back to you once we've had time to review this 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generics, as documented in pydantic's docs do not work.
Repro: Use the example from pydantic's docs. The typevar type does not get validated.
For example:
Response[int](data="not an int")does not raise an error.Furthermore, json schema generation is broken, as described here: #1002
This PR: