-
Couldn't load subscription status.
- Fork 21
Create GitHub Action CI file #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger Swift against da378c6 |
Package.swift
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try setting this to 5.5?
.github/workflows/swift.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generate-xcodeproj is deprecated. We're now using xcodebuild directly through fastlane scan, which results in the following output:
[13:10:35]: $ set -o pipefail && cd WeTransferPRLinter/ && env NSUnbufferedIO=YES xcodebuild -scheme WeTransferPRLinter -destination 'platform=macOS' -resultBundlePath 'build/reports/WeTransferPRLinter.xcresult' -enableCodeCoverage YES -clonedSourcePackagesDirPath /Users/vagrant/git/.build build test | tee '/Users/vagrant/Library/Logs/scan/WeTransferPRLinter.log' | xcpretty --report junit --output '/var/folders/g2/xnd8hpjs50v433gfrybz2nxh0000gn/T/junit_report20211025-1719-128l68k'
In other words, you can skip generating the Xcode project and just use xcodebuild directly on the package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I knew was deprecated, but didn't know I could use xcodebuild directly, that is pretty cool! thank you :)
@f-meloni what is the status of this? Our tests are still failing using the Danger master branch :(
No description provided.