-
-
Notifications
You must be signed in to change notification settings - Fork 143
Multi-select dropdown component #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rargumedo-mccorvey
rargumedo-mccorvey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks already amazing. Love to see it merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Here I propose the addition of a simple mult-selector dropdown component as illustrated in the gif below
multiselect_dropdown_example
This PR includes functionality for this component, including the following new files
multi_select_test.js: a simple controller in src to power multi-select functionalitymulti_select.html: a fixture for testing the componentmulti_select_test.js: a set of tests for the multi-select component fixturemulti-select.md: a doc outlining usage of the component (as well as a gif illustrationmulti-selector.gif)The PR also contains necessary adjustments to several files (e.g.,
index.jsin src andindex.htmlat root) for illustration of the component on the main demo page.The associated component tests are run along with the others via
npm run test.