-
Couldn't load subscription status.
- Fork 13
Bring links up to date #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a minimum, we should also update line 234 to reflect the renamed @ethereum/tx library name though I would recommend just removing this entire section since we don't really support keythereum or ethereumjs-wallet anymore. People should use ethers for managing keys/wallets.
@acolytec3 EthereumJS Wallet has > 130.000 weekly downloads, let's please not make deprecation decisions on such libraries here so much on the sideline. 😋
@acolytec3 EthereumJS Wallet has > 130.000 weekly downloads, let's please not make deprecation decisions on such libraries here so much on the sideline
Could we deprecate in favor of @paulmillr's micro-eth-signer? Otherwise, shouldn't we pull it into the monorepo and actively maintain it?
@acolytec3 EthereumJS Wallet has > 130.000 weekly downloads, let's please not make deprecation decisions on such libraries here so much on the sideline
Could we deprecate in favor of @paulmillr's micro-eth-signer? Otherwise, shouldn't we pull it into the monorepo and actively maintain it?
Again, "500.000 Downloads/months library deprecation decisions" are really not such an easy take (this was in discussion a couple of times during the last 2-3 years). E.g. Metamask (yes (!)) is using this wallet.
I don't see the necessity to move to monorepo TBH, this has no interdependencies to other libs. So, the current state is: this is one of our maintained (or: should be maintained) libraries.
paulmillr
commented
Jul 24, 2022
@holgerd77 want me to take a look at upgrading ethereumjs-wallet to latest ethereum-cryptography?
@holgerd77 want me to take a look at upgrading ethereumjs-wallet to latest ethereum-cryptography?
Oh, that would be nice, yes! 👍
Replace "projects" section of
index.mdwith markdown from the monorepo README that has up to date links and package list.If the team decides to maintain this site, more intention could be put into the design and content, but this at least fixes this issue of deprecated links.