-
Notifications
You must be signed in to change notification settings - Fork 21.4k
core/rawdb: reduce allocations in *key methods #33006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MariusVanDerWijden
wants to merge
1
commit into
ethereum:master
from
MariusVanDerWijden:rawdb-reduce-allocs-2
Open
core/rawdb: reduce allocations in *key methods #33006
MariusVanDerWijden
wants to merge
1
commit into
ethereum:master
from
MariusVanDerWijden:rawdb-reduce-allocs-2
+22
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@MariusVanDerWijden
MariusVanDerWijden
requested a review
from rjl493456442
as a code owner
October 23, 2025 10:34
Pls don't merge yet, I have some more improvements in the pipeline
7fantasy7
7fantasy7
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the allocation in certain methods. This will reduce overall allocations by 5-10% during snap sync.
The issue is that the compiler does not know that the keys are const, thus it can't allocate the keys on the stack.
All methods that take in var length parameters, e.g
trienodeHistoryIndexKeycan't be optimized like this, since the compiler does not know thatpathis only of a certain size