Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

core/types: optimize modern signer #32971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cuiweixie wants to merge 3 commits into ethereum:master
base: master
Choose a base branch
Loading
from cuiweixie:optimize_modernSigner

Conversation

@cuiweixie
Copy link
Contributor

@cuiweixie cuiweixie commented Oct 20, 2025
edited
Loading

goos: darwin
goarch: arm64
pkg: github.com/ethereum/go-ethereum/core/types
cpu: Apple M1 Pro
 │ old.txt │ new.txt │
 │ sec/op │ sec/op vs base │
_modernSigner_Equal-10 101.65n ± 1% 10.29n ± 0% -89.88% (p=0.000 n=20)
 │ old.txt │ new.txt │
 │ B/op │ B/op vs base │
_modernSigner_Equal-10 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=20) 1
1 all samples are equal
 │ old.txt │ new.txt │
 │ allocs/op │ allocs/op vs base │
_modernSigner_Equal-10 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=20) 1
1 all samples are equal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjl fjl fjl left review comments

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

At least 1 approving review is required to merge this pull request.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /