Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

internal/jsre: pass only extra args to setTimeout/setInterval callbacks #32936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anim001k wants to merge 1 commit into ethereum:master
base: master
Choose a base branch
Loading
from anim001k:patch-3

Conversation

@anim001k
Copy link

@anim001k anim001k commented Oct 17, 2025

Description

  • Summary: Correct the JS timer callback argument forwarding to match standard JS semantics.
  • What changed: In internal/jsre/jsre.go, the callback is now invoked with only the arguments after the callback and delay.
  • Why: Previously, the callback received the function and delay as parameters, causing unexpected behavior and logic bugs for consumers.

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great catch!

Copy link
Author

LGTM, great catch!

@MariusVanDerWijden thanks!

Copy link
Author

@MariusVanDerWijden is it ok to be merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /