-
Notifications
You must be signed in to change notification settings - Fork 7.7k
ci(hosted): Copy esp-hosted binaries to gh-pages #11957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello lucasssvaz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of Change
This pull request enhances the release workflow to support the handling and distribution of esp-hosted binaries. It introduces steps to copy these binaries during the release process, uploads them as build artifacts, and then commits them to the
gh-pagesbranch for distribution. The main changes are grouped below:Release Script and Artifact Handling:
.github/scripts/on-release.shto copy esp-hosted.binfiles from the build output to a newhosteddirectory in the workspace, preparing them for upload..github/workflows/release.ymlto upload thehostedbinaries as a build artifact after the main release script runs.Distribution via GitHub Pages:
upload-hosted-binariesjob to the workflow that:gh-pagesbranch.hostedbinaries artifact.gh-pages, making them available for distribution.