fix(net): Rework NO_GLOBALS to not act on dependent network classes #11933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

me-no-dev merged 1 commit into master from bugfix/no_globals

Oct 20, 2025

Merged

fix(net): Rework NO_GLOBALS to not act on dependent network classes #11933

me-no-dev merged 1 commit into master from bugfix/no_globals

Oct 20, 2025

+4 −6

Conversation

@me-no-dev

Copy link

Member

@me-no-dev me-no-dev commented Oct 20, 2025

This pull request standardizes the way global instances are conditionally defined across several network-related libraries. Specifically, it ensures that global objects like WiFi, ETH, PPP, Network, and MDNS are only instantiated when the appropriate macros are not defined, improving consistency and configurability throughout the codebase.

Conditional global instance definitions:

Added #if !defined(NO_GLOBAL_INSTANCES) && !defined(NO_GLOBAL_ETH) guard around the global ETH instance in ETH.cpp for consistency with other modules.
Added #if !defined(NO_GLOBAL_INSTANCES) && !defined(NO_GLOBAL_PPP) guard around the global PPP instance in PPP.cpp.
Removed unconditional global instance declarations and ensured that WiFi, Network, and MDNS are only declared when the appropriate macros are not defined in their respective header files (WiFi.h, NetworkManager.h, ESPmDNS.h). [1] [2] [3]

Closes: #11871

@me-no-dev


 fix(net): Rework NO_GLOBALS to not act on dependent network classes

9e58504

@me-no-dev me-no-dev added the Status: Review needed label

Oct 20, 2025

@github-actions

Copy link

Contributor

github-actions bot commented Oct 20, 2025 •

edited

Loading

Test Results

76 files 76 suites 15m 7s ⏱️
38 tests 38 ✅ 0 💤 0 ❌
241 runs 241 ✅ 0 💤 0 ❌

Results for commit 9e58504.

♻️ This comment has been updated with latest results.

@github-actions

Copy link

Contributor

github-actions bot commented Oct 20, 2025

Messages
📖	🎉 Good Job! All checks are passing!

👋 Hello me-no-dev, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 9e58504