-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix example for real-life usage for lesson 2 #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kentcdodds
merged 1 commit into
epicweb-dev:main
from
sophiabrandt:replace-tooltip-with-tabs-for-lesson-02
Dec 12, 2020
Merged
Fix example for real-life usage for lesson 2 #56
kentcdodds
merged 1 commit into
epicweb-dev:main
from
sophiabrandt:replace-tooltip-with-tabs-for-lesson-02
Dec 12, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I could not find examples of the pattern (`React.Children.map` and `React.cloneElement`) in `@reach/tooltip`. This was very confusing during the exercise. In comparison, `@reach/tabs` uses that pattern in [their sources code](https://github.com/reach/reach-ui/blob/97b32791ce33f822f6bc9f07f6cebfb343d8032d/packages/tabs/src/index.tsx#L383).
kentcdodds
kentcdodds
approved these changes
Dec 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for investigating and fixing this!
@all-contributors please add @sophiabrandt for docs
I've put up a pull request to add @sophiabrandt! 🎉
@sophiabrandt
sophiabrandt
deleted the
replace-tooltip-with-tabs-for-lesson-02
branch
December 12, 2020 14:59
payapula
pushed a commit
to payapula/advanced-react-patterns
that referenced
this pull request
May 22, 2022
I could not find examples of the pattern (`React.Children.map` and `React.cloneElement`) in `@reach/tooltip`. This was very confusing during the exercise. In comparison, `@reach/tabs` uses that pattern in [their sources code](https://github.com/reach/reach-ui/blob/97b32791ce33f822f6bc9f07f6cebfb343d8032d/packages/tabs/src/index.tsx#L383).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not find examples of the pattern (
React.Children.mapandReact.cloneElement) in@reach/tooltip. This was very confusing during the exercise.In comparison,
@reach/tabsuses that pattern in its source code.