Skip to content

telescope favicon #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

kentcdodds merged 1 commit into epicweb-dev:main from Aprillion:main

Oct 4, 2020

Merged

telescope favicon #33

kentcdodds merged 1 commit into epicweb-dev:main from Aprillion:main

Oct 4, 2020

Conversation

Copy link

Contributor

@Aprillion Aprillion commented Oct 2, 2020

No description provided.

Copy link

Member

kentcdodds commented Oct 2, 2020

Thanks! Could we do this one instead?

04-advanced-react-patterns

Copy link

Contributor Author

Aprillion commented Oct 3, 2020

Thanks! Could we do this one instead?

Oh, I had a feeling I was missing something when doing the Friday night commits 🤦‍♂️
I will update all my PRs, thanks for the feedback!


 telescope favicon

6e7478b

@Aprillion Aprillion force-pushed the main branch from 9a19f8b to 6e7478b Compare

October 3, 2020 07:40

@Aprillion Aprillion changed the title ~~(削除) rocket favicon (削除ここまで)~~ (追記) telescope favicon (追記ここまで)

Copy link

Contributor Author

Aprillion commented Oct 3, 2020

Ufff, all PRs updated and double checked (fun fact: amending commits is much more fun when you have write access).
Here is a script to tripple check them all after merging...

`react-fundamentals
react-hooks
advanced-react-hooks
advanced-react-patterns
react-performance
react-suspense
testing-react-apps`.split('\n').forEach(repo => open(`https://raw.githubusercontent.com/kentcdodds/${repo}/main/public/favicon.ico`))

@kentcdodds kentcdodds merged commit fce3e2c into epicweb-dev:main

Copy link

Member

kentcdodds commented Oct 4, 2020

@all-contributors please add @Aprillion for code

@allcontributors allcontributors bot mentioned this pull request

docs: add Aprillion as a contributor #37

Merged

@allcontributors

Copy link

Contributor

allcontributors bot commented Oct 4, 2020

I've put up a pull request to add @Aprillion! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment