Skip to content

Update README.md #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

mayank1897 wants to merge 2 commits into epicweb-dev:main from mayank1897:main

Closed

Update README.md #28

mayank1897 wants to merge 2 commits into epicweb-dev:main from mayank1897:main

Conversation

Copy link

@mayank1897 mayank1897 commented Oct 1, 2020

No description provided.

mayank1897 added 2 commits

October 1, 2020 19:49


 Update README.md

96dd35e


 Update README.md

ca4e20c

JacobMGEvans approved these changes

View reviewed changes

Copy link

@JacobMGEvans JacobMGEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering line 136 is using a period and these are proper sentences I would tend to agree with this change. Thank you @mayank1897

Copy link

Author

mayank1897 commented Oct 1, 2020

try to merge it.

Copy link

JacobMGEvans commented Oct 1, 2020

try to merge it.

That is ultimately up to Kent

Copy link

therealklanni commented Oct 1, 2020

Hacktober spam

Copy link

Author

mayank1897 commented Oct 1, 2020

changing the README.md for better readability.....it's not a Hacktober spam!!

Copy link

Member

kentcdodds commented Oct 1, 2020

Thanks for the contribution. I believe you made it in good faith, but I disagree that this is an improvement so I won't be merging it. Thanks anyway :)

@kentcdodds kentcdodds closed this

@kentcdodds kentcdodds added the invalid label

Copy link

JacobMGEvans commented Oct 1, 2020

changing the README.md for better readability.....it's not a Hacktober spam!!

It was worth a shot. Hope you find other things to improve 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants

@mayank1897 @JacobMGEvans @therealklanni @kentcdodds