-
Couldn't load subscription status.
- Fork 1.3k
fix: disable new jsx transform #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
react-scripts@4.0.0 introduce new jsx transformer, because of that, overiding React's `createElement` would not work anymore. set env of `DISABLE_NEW_JSX_TRANSFORM` to keep using the old jsx transform so that the tests would pass ([source][1]) it's a temporary solution [1]: facebook/create-react-app@2b1161b#diff-4f6f41a4cff8d78483f30bcf1befa1a002c4995cf9cd2ab6622eed82db48530cR13
@zhuangya
zhuangya
force-pushed
the
disable-new-jsx-transform
branch
from
October 24, 2020 17:25
530b824 to
8b73fba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-scripts@4.0.0 introduce new jsx transformer, because of that,
overiding React's
createElementwould not work anymore.set env of
DISABLE_NEW_JSX_TRANSFORMto keep using the old jsxtransform so that the tests would pass (source)
it's a temporary solution