Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Email fill script does not work on Windows #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kentcdodds merged 1 commit into epicweb-dev:master from frankcalise:patch-2
May 11, 2019

Conversation

@frankcalise
Copy link
Contributor

@frankcalise frankcalise commented May 11, 2019

Tested this and it works locally on Windows 10 with vscode. Would need someone to test the regex on Mac as I don't have one.

I imagine this could be done to the other projects as I remember having this issue in learn-react-hooks as well.

Tested this and it works locally on Windows 10 with vscode. Would need someone to test the regex on Mac as I don't have one.
I imagine this could be done to the other projects as I remember having this issue in learn-react-hooks as well.
Copy link

codecov bot commented May 11, 2019

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## master #7 +/- ##
=======================================
 Coverage 59.37% 59.37% 
=======================================
 Files 14 14 
 Lines 256 256 
 Branches 13 13 
=======================================
 Hits 152 152 
 Misses 99 99 
 Partials 5 5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a1c71...fdf7740. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll bet that works just fine on mac. I'll test it to be sure, but I expect it works fine.

Thank you so much Frank. You've been awesome!

@kentcdodds kentcdodds merged commit d79dc39 into epicweb-dev:master May 11, 2019
SpencerHaan pushed a commit to SpencerHaan/advanced-react-hooks that referenced this pull request Jan 25, 2022
* docs: update README.md
* docs: update .all-contributorsrc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /