Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

documentation: Update verbiage to be more readable #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kentcdodds merged 1 commit into epicweb-dev:main from CNate:grammar-suggestion
May 4, 2023

Conversation

@CNate
Copy link
Contributor

@CNate CNate commented May 4, 2023

While reading this section, the sentence on line 125 read awkwardly to me even as a native speaker. Particularly between the implied pause between "though" and "it". I understand the intent and it might be just me; since it gave me pause, I thought it might be worth addressing.

While reading this section, this particular sentence read awkwardly to
me even as a native speaker. Particularly between the implied pause
between "though" and "it". I understand the intent and it might be just
me; since it gave me pause, I thought it might be worth addressing.
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was missing a word which made it confusing. Thanks for the improvement!

@kentcdodds kentcdodds merged commit 56c8264 into epicweb-dev:main May 4, 2023
Copy link
Member

@all-contributors please add @CNate for docs

CNate reacted with heart emoji

Copy link
Contributor

@kentcdodds

I've put up a pull request to add @CNate! 🎉

CNate reacted with hooray emoji

@CNate CNate deleted the grammar-suggestion branch May 4, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /