Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Clamp remove value to 0 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kentcdodds merged 1 commit into epicweb-dev:master from JonathanBruce:patch-1
Jul 25, 2019
Merged

Conversation

@JonathanBruce
Copy link
Contributor

@JonathanBruce JonathanBruce commented Jul 24, 2019

If the message array length equals 0, the second slice param becomes -1 which refills the messages array up to the first index.

If the message array length equals 0, the second slice param becomes -1 which refills the messages array up to the first index.
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## master #15 +/- ##
=======================================
 Coverage 57.37% 57.37% 
=======================================
 Files 13 13 
 Lines 244 244 
 Branches 13 13 
=======================================
 Hits 140 140 
 Misses 99 99 
 Partials 5 5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41146ca...fd8acfc. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thank you!

@kentcdodds kentcdodds merged commit c1b5e8f into epicweb-dev:master Jul 25, 2019
Copy link
Member

@all-contributors please add @JonathanBruce for code

JonathanBruce reacted with thumbs up emoji

Copy link
Contributor

@kentcdodds

I've put up a pull request to add @JonathanBruce! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /