fix test for useReducer, simpleCounter example #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kentcdodds merged 1 commit into epicweb-dev:main from tsargent:fix-test

May 21, 2021

Merged

fix test for useReducer, simpleCounter example #139

kentcdodds merged 1 commit into epicweb-dev:main from tsargent:fix-test

May 21, 2021

Conversation

@tsargent

Copy link

Contributor

@tsargent tsargent commented May 21, 2021

The code that looks for "commentLessLines" ends up filtering unintended lines . Counter.toString() returns this:

function Counter({
 initialCount = 0,
 step = 1
 }) {
 // 🐨 replace React.useState with React.useReducer.
 // 💰 React.useReducer(countReducer, initialCount)
 const [count, setCount] = React.useReducer(countReducer, initialCount); // 💰 you can write the countReducer function so you don't have to make any
 // changes to the next two lines of code! Remember:
 // The 1st argument is called "state" - the current value of count
 // The 2nd argument is called "newState" - the value passed to setCount
 
 const increment = () => setCount(count + step);
 
 return /*#__PURE__*/(0, _jsxDevRuntime.jsxDEV)("button", {
 onClick: increment,
 children: count
 }, void 0, false, {
 fileName: _jsxFileName,
 lineNumber: 18,
 columnNumber: 10
 }, this);
 }

As you can see, the non-comment code with React.useReducer is on a line that ends with a comment, but this whole line will be filtered out, and the test will fail. We might want to instead look for lines that begin with comments: l.trim().substr(0, 2).includes('//')