-
Couldn't load subscription status.
- Fork 1.3k
refactor(project): improve typescript branch #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
suddenlyGiovanni
wants to merge
3
commits into
epicweb-dev:ts/main
from
suddenlyGiovanni:pr/refactor-typescript
Closed
refactor(project): improve typescript branch #120
suddenlyGiovanni
wants to merge
3
commits into
epicweb-dev:ts/main
from
suddenlyGiovanni:pr/refactor-typescript
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@suddenlyGiovanni
suddenlyGiovanni
force-pushed
the
pr/refactor-typescript
branch
3 times, most recently
from
January 25, 2021 17:23
a7d5464 to
d70016e
Compare
@suddenlyGiovanni
suddenlyGiovanni
marked this pull request as ready for review
January 25, 2021 17:23
refactor(project): convert entry files to typescript refactor(exercise-01): convert to typescript react refactor(exercise-01): to ts: extra credit 1. accept the step as the action refactor(exercise-01): to ts: extra credit 2. simulate setState with an object refactor(exercise-01): to ts: extra credit 3. simulate setState with object|function refactor(exercise-01): to ts: extra credit 4. traditional dispatch object refactor(pokemon.js): to ts refactor(exercise-02): to ts refactor(exercise-02): to ts: extra credit 1: use useCallback refactor(exercise-02): to ts: extra credit 2: return a memoized run function from useAsync refactor(exercise-02): to ts: extra credit 3: make safeDispatch refactor(final): move typescript final solution to `src/final-ts/` refactor(exercise-03): to ts refactor(exercise-03): to ts: extra credit 1: create a consumer hook refactor(exercise-03): to ts: extra credit 2: caching in a context provider refactor(exercise-04): to ts refactor(exercise-05): to ts refactor(exercise-06): to ts
@suddenlyGiovanni
suddenlyGiovanni
force-pushed
the
pr/refactor-typescript
branch
from
February 10, 2021 15:38
d70016e to
0241828
Compare
Thanks again for the PR. I've finished my own updates. If you find ways to improve what I've done in the next branch feel free to let me know :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As for PR: https://github.com/kentcdodds/react-hooks/pull/112#issue-554331129
Story
AC:
./src/exercisesfolder with no consequences../src/final-ts/should be refactored to TypeScript.4.1. The codebase should remain as close as possible to @kentcdodds's initial implementation.
4.2. Should avoid distracting the user with complicated type signatures