-
-
Couldn't load subscription status.
- Fork 20
User and password authentication #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! 😄
Great feature!! ❤️
After checking the code I want to suggest some changes that in my opinion helps the project to stay clean avoiding implicit actions in the initialization of NocoDBClient. 🌟
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about having a HTTP request in the NocoDBRequestsClient initialization. I suggest creating a class with the purpose of retrieving the AuthToken.
classDiagram
class NocoDBAuthClient {
<< interface >>
+get_auth_token() AuthToken
}
class NocoDBAuthRequestsClient {
+get_auth_token() AuthToken
}
NocoDBAuthClient <|-- NocoDBAuthRequestsClient
Usage example:
auth_client = NocoDBAuthRequestsClient("username", "password") auth_token = auth_client.get_auth_token() client = NocoDBRequestsClient(base_uri, auth_token)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change has nothing to do with the commit.
39a678d to
7a739e1
Compare
99907ce to
3dd40a3
Compare
No description provided.