-
Notifications
You must be signed in to change notification settings - Fork 810
deal with nil document types in Multimodel
#978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
picandocodigo
merged 1 commit into
elastic:master
from
catwell:pr-multimodel-without-types
Mar 1, 2021
Merged
deal with nil document types in Multimodel
#978
picandocodigo
merged 1 commit into
elastic:master
from
catwell:pr-multimodel-without-types
Mar 1, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 CLA has been signed
Thank you for this contribution @catwell!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simplest solution to deal with the removal of types in ElasticSearch is simply to use single-type indices and not set
document_typeon models.However Multimodel did not deal with that case and ended up calling a URL ending in
my-index//_searchinstead ofmy-index/_search, which caused the types warning:This PR fixes that issue.