Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[MODEL] Fix wrong retrieval of records corresponding to indexed documents when querying multiple models #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
miguelff wants to merge 3 commits into elastic:master from miguelff:369-fix-unmarshalling

Conversation

@miguelff
Copy link
Contributor

@miguelff miguelff commented Apr 17, 2015

This PR fixes #369

  • The first commit adds a fix for a regression introduced in Force no_timeout in mongoid adapter #335 , to depart from a green build
  • The second commit includes:
    • A refactor over a case/when statement, as for objects. case/when only matches the branches in which === returns true. i.e. an object that is instance of a class. But if the object is a class itself, or a module like the adapters, it won't enter any of the when branches.
    • Taking back the call to compact over the collection of records, because as per eventual consistency, ES can return some results, which corresponding records no longer exist. As a consequence, calling records would return an array with positions including nil.
    • An integration test checking the correctness of the two points above.
  • The third commit cleans up a bit the integration tests for multiple model.

@miguelff miguelff changed the title (削除) 369 fix unmarshalling (削除ここまで) (追記) [MODEL] Fix wrong retrieval of records corresponding to indexed documents when querying multiple models (追記ここまで) Apr 17, 2015
karmi pushed a commit that referenced this pull request Apr 22, 2015
@karmi karmi closed this in 5fb9c56 Apr 22, 2015
karmi pushed a commit that referenced this pull request Apr 22, 2015
karmi added a commit that referenced this pull request Apr 22, 2015
karmi added a commit that referenced this pull request Apr 22, 2015
Copy link
Contributor

karmi commented Apr 22, 2015

@miguelff Thanks, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[MODEL] Wrong retrieval of records corresponding to indexed documents when querying multiple models.

2 participants

AltStyle によって変換されたページ (->オリジナル) /