-
Couldn't load subscription status.
- Fork 808
Will paginate offset & length #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lleger
commented
Jul 19, 2014
Works for me 👍
what does this PR need to be pushed through? I'm not sure whats up with travis, but this does work on my dev machine and the tests pass.
@meesterdude I'll have a look at it this week. Was held up with something else.
@meesterdude It seems like you haven't signed the CLA, by the way, could you do it, please?
@karmi actually I did that first thing; I have the echosign doc in my inbox, do I need to forward it somewhere?
@meesterdude Great, no need to forward, should be in our systems then!
So, finally merged & pushed it, thanks!
was this correctly merged? GH reports unmerged commits; and i'm getting undefined methodoffset' for #Elasticsearch::Model::Response::Results:0x007fcd532da7f8`
hrm nevermind, looks like the code is there, not sure why GH is reporting unmerged commits then.
This is to address the change needed for #135, which is to address #131.
@lleger @johvet does this work for you?