Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Merge 8.x into main #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picandocodigo merged 38 commits into main from 8.x
Apr 16, 2024
Merged

Merge 8.x into main #1077

picandocodigo merged 38 commits into main from 8.x
Apr 16, 2024

Conversation

@picandocodigo
Copy link
Member

@picandocodigo picandocodigo commented Apr 16, 2024

With this Pull Request, the 8.x branch will be merged into main to follow the 8.x Elasticsearch releases. The previous main code which followed the 7.x releases is now branched into 7.x, which should be used with Elasticsearch 7.x releases.

An 8.0.0.pre release will follow.

pquentin reacted with hooray emoji pquentin reacted with rocket emoji
Replaces Elasticsearch::Transport with Elastic::Transport
Removes type
Updates option hash/keyword argument expectations
Updates usage of client
I need to understand if we still need MultiModel or if it was based on
the document_type which is no longer a thing in Elasticsearch.
- Adds Ruby 3.0 tests
- Removes Ruby 2.6 and 2.7 tests
sinisterchipmunk and others added 8 commits April 12, 2024 15:47
The goal of ClassMethodsProxy is to avoid polluting the target's namespace,
but it was possible to do this by accident when calling `class_eval` before
ActiveSupport was completely loaded. This test ensures the namespace isn't
polluted, regardless of the load state of ActiveSupport.
ActiveSupport patches Kernel to add `class_eval` but this behavior wasn't
loaded in the test environment. This created a discrepancy between test
and prod, causing tests to fail that should have passed and vice versa.
Fully loading ActiveSupport makes the test environment more accurate.
@picandocodigo picandocodigo added the 8.x 8.x branch to use with Elasticsearch 8.x label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

8.x 8.x branch to use with Elasticsearch 8.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /