-
Notifications
You must be signed in to change notification settings - Fork 808
Merge 8.x into main #1077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Merge 8.x into main #1077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces Elasticsearch::Transport with Elastic::Transport
Removes type Updates option hash/keyword argument expectations
Updates usage of client
...whitespace cleanup
I need to understand if we still need MultiModel or if it was based on the document_type which is no longer a thing in Elasticsearch.
- Adds Ruby 3.0 tests - Removes Ruby 2.6 and 2.7 tests
The goal of ClassMethodsProxy is to avoid polluting the target's namespace, but it was possible to do this by accident when calling `class_eval` before ActiveSupport was completely loaded. This test ensures the namespace isn't polluted, regardless of the load state of ActiveSupport.
ActiveSupport patches Kernel to add `class_eval` but this behavior wasn't loaded in the test environment. This created a discrepancy between test and prod, causing tests to fail that should have passed and vice versa. Fully loading ActiveSupport makes the test environment more accurate.
@picandocodigo
picandocodigo
added
the
8.x
8.x branch to use with Elasticsearch 8.x
label
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this Pull Request, the
8.xbranch will be merged intomainto follow the8.xElasticsearch releases. The previousmaincode which followed the7.xreleases is now branched into7.x, which should be used with Elasticsearch7.xreleases.An
8.0.0.prerelease will follow.