-
Notifications
You must be signed in to change notification settings - Fork 808
Update the opensearch-rails gem (RM-2427) #1070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the opensearch-rails gem (RM-2427) #1070
Conversation
...ch module name to OpenSearch
...espace to opensearch
...sticsearch-with-opensearch Replace elasticsearch with opensearch
* Pin opensearch-ruby to version 1 * Bump version to 0.1.1 and add changelog entry * Pin opensearch version to 1 in github workflows
...nsearch-2 Support OpenSearch 2 by removing deprecated mapping types
- Fix tests in opensearch-model: rspec mocks expects keyword arguments when
using the syntax `with(options: 'value')` but the real code uses a `options`
hash. Fixed by explicitly defining a `Hash` as the argument: `with({ options:
'value'})`
- Add support for Rails 7.1 (wip).
- Fix pagination tests by including the `OpenSearch::Model::Importing` manually. Not sure why this is necessary.
- Fix `searching_search_request_spec.rb`: explicitly expect a options hash instead of keyword arguments when stubbing.
- Fix `opensearch-model/spec/opensearch/model/adapters/active_record/import_spec.rb` tests.
- Fix activerecord & mongoid tests.
- Fix namespaced_model_spec test.
- Remove support for unsupported Rails versions. At the time of writing from Rails 6.1 upwards is still supported [1]. - Set minimum supported Ruby version to 2.5 since this is the minimum supported version by Rails 6 [1]. [1]: https://www.fastruby.io/blog/ruby/rails/versions/compatibility-table.html
- Update opensearch-ruby from version 2 to 3.
- Make logger formatter for opensearch-model nil safe. It seems that sometimes a message (`m`) is `nil`.
- Remove github workflows for Ruby < 2.7. - Add github workflow for Ruby 3.2 and (hopefully) fix 2.7 (untested).
❌ Author of the following commits did not sign a Contributor Agreement:
7c76f72, e729955, 901be2b, 5163442, a0c9c1b, a7f1ae3, c56e83c, ca41528, bd1a955, 568312e, a225260, 85ff162, 54607b8, a4f100f, 3822088, b262e8a, 3ad0a17, 5531f55, da7c666, bdb6a38, ebf8442, 79a5d00, 6900eb5, 5bbe5aa, 9df9c4f, 7cb2302, 7f7dbde, 54f2ba4, 958e538, e128c9e, c42f492, cc8a707, 4174f66, 609bbd2, 5c1f35d, 686f69c, 39bdf39, 978ab3f, 4aad178, e546907, 5e59841
Please, read and sign the above mentioned agreement if you want to contribute to this project
Hi @mauricebolhuis. Thanks for checking in, but I'm not sure that "Use opensearch-ruby instead of elasticsearch gem + rename Elasticsearch module name to OpenSearch" is on our roadmap right now. We would be happy to receive your contributions to the original Elasticsearch projects in future though.
No description provided.