Address Rails 7.1 deprecation warning in elasticsearch-rails #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

picandocodigo merged 1 commit into elastic:main from maciek-rr:misc/address-rails-7-1-log-subscriber-deprecation

May 14, 2024

Merged

Address Rails 7.1 deprecation warning in elasticsearch-rails #1067

picandocodigo merged 1 commit into elastic:main from maciek-rr:misc/address-rails-7-1-log-subscriber-deprecation

May 14, 2024

Conversation

@maciek-rr

Copy link

Contributor

@maciek-rr maciek-rr commented Dec 27, 2023 •

edited

Loading

Description

This PR switches the elasticsearch-rails gem to use a new signature of the ActiveSupport::LogSubscriber#color
method when called in an app using Rails 7.1+.

With older Rails, the gem uses the working, old signature.

An example of a deprecation warning visible in 7.1 apps

DEPRECATION WARNING: Bolding log text with a positional boolean is deprecated and will be removed in Rails 7.2. Use an option hash instead (eg. `color("my text", :red, bold: true)`). (called from query_time_boundaries at timeseries/frequency_calculator.rb:44)

@maciek-rr


 Address Rails 7.1 deprecation warning in elasticsearch-rails

927a77e

This PR switches the elasticsearch-rails gem to use a new signature
of the ActiveSupport::LogSubscriber#color method when called in an
app using Rails 7.1+. With older Rails, the gem uses the working, old
signature.

@N0xFF N0xFF mentioned this pull request

Feb 8, 2024

Deprecation warning in Rails 7.1 (support Rails 7.2) #1071

Open

@spuyet

Copy link