Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Adds Cohere inference service notebook #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szabosteve merged 6 commits into main from szabosteve/inference-cohere-notebook
Mar 13, 2024

Conversation

@szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Mar 12, 2024
edited
Loading

Overview

Related to https://github.com/elastic/search-docs-team/issues/71
This PR adds a Jupyter notebook that contains an end-to-end example of using the Inference API with the Cohere service.
It also makes some changes in the OpenAI notebook to make it more exact.

Preview

Open In Colab

@szabosteve szabosteve added the documentation Improvements or additions to documentation label Mar 12, 2024
Copy link

gitnotebooks bot commented Mar 12, 2024

Found 2 changed notebooks. Review the changes at https://gitnotebooks.com/elastic/elasticsearch-labs/pull/204

Copy link
Collaborator

@szabosteve Hey, you may want to add this notebook to the testing exception list on this file, since we are unable to run tests for notebooks that depend on third-party services at this time.

Copy link
Contributor Author

Thanks for the info, @miguelgrinberg! I've added the notebook to the exempt list via d760dd4.

Copy link
Member

joemcelroy commented Mar 12, 2024
edited
Loading

Hey @szabosteve - could you move this notebook to a new folder called cohere please? https://github.com/elastic/elasticsearch-labs/tree/main/notebooks/integrations

Also failing the pre-commit stage. take a look at contributing.md

Copy link
Contributor Author

@joemcelroy Yup, I did it via 6ece101. It seems the pre-commit hook is also passed.

Copy link
Contributor

Looks great, nice and clean! 👏

One open question about needing a paid Cohere account. If there is a workaround to use trial API keys, it might be worth considering. This would maximize accessibility. We already set the bar pretty high because you need an Elastic Cloud account.

Copy link
Contributor Author

Thanks for the review! I have a workaround that is a bit more complicated but makes the bulk request unnecessary, so users without a paid Cohere account can use it. I proposed adding it to the OpenAI notebook but the decision was to remove that option for more clarity.

@szabosteve szabosteve merged commit 3d79e13 into main Mar 13, 2024
@szabosteve szabosteve deleted the szabosteve/inference-cohere-notebook branch March 13, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joemcelroy joemcelroy joemcelroy approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /