-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: Add enhanced node repair configuration support #8512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit implements comprehensive enhanced node repair configuration for EKS managed nodegroups with the following features: - Support for percentage and count-based unhealthy node thresholds - Configurable parallel repair limits (percentage and count) - Advanced node repair config overrides for specific conditions - Full CLI flag support for all new parameters - Complete YAML configuration file support - Backward compatibility with existing configurations Key changes: - Extended API types with new NodeRepairConfigOverride struct - Added CLI flags for all new parameters - Updated CloudFormation builder for AWS EKS integration - Comprehensive unit and integration tests - Updated documentation and examples - Enhanced JSON schema validation CLI Examples: eksctl create cluster --enable-node-repair --node-repair-max-unhealthy-percentage=25 eksctl create nodegroup --enable-node-repair --node-repair-max-parallel-count=2 Config Examples: nodeRepairConfig: enabled: true maxUnhealthyNodeThresholdPercentage: 20 maxParallelNodesRepairedCount: 2 nodeRepairConfigOverrides: - nodeMonitoringCondition: NetworkNotReady nodeUnhealthyReason: InterfaceNotUp repairAction: Restart minRepairWaitTimeMins: 15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
gopikrishna-rafay
commented
Oct 22, 2025
Hey, Any progress on when this is going to be merged. I tried out the changes but found AWS cloud stack for nodegroup still doesnt support these additional fields. Please update if any changes.
@gopikrishna-rafay yeah, it seems that CFN does not support these new parameters for node repair configuration yet. We are trying to get it unblocked soon. Please use aws cli or SDK for the time being.
Uh oh!
There was an error while loading. Please reload this page.
Description
This PR extends the existing node repair configuration in eksctl to support the full range of AWS EKS node repair parameters. The current implementation only supports a boolean
enabledflag, but AWS EKS supports additional parameters for fine-grained control over node repair behavior including thresholds, parallel repair limits, and custom repair overrides, as defined in EKS doc: https://docs.aws.amazon.com/eks/latest/APIReference/API_NodeRepairConfig.htmlChecklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯