-
Notifications
You must be signed in to change notification settings - Fork 908
Add language-change part in the README files #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add translation link
Spanish -> Español
Add translation link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GimunLee good idea. 💡
laguage-change
really wish there was a way of keeping this updated automatically ... 💭
really wish there was a way of keeping this updated automatically ... 💭
See #329
Still have concerns around #271 - unless we have a maintainer able to hop on every PR for the main readme to do a manual translation (or some other way to outsource it), then the new translated readmes may get out of date. Alternative: never change the readme or code significantly :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Long-term still unsure how I feel with having translated readmes in here, but I appreciate having an up-to-date translated readme so wouldn't say no :-) Thanks for this improvement as well!
nit: we could add links from Spanish back to these, though the Spanish one is just a placeholder with a warning, so not necessary in my opinion.
@mckennapsean yeah, agree with everything you've written above. 👍
I feel that this tutorial is pretty "stable" now so don't expect too many changes in the near future. 💭
When I saw README file of this repository, I thought it would be better it have language-change part(English, Korean, Spanish). So, I have added it
If you don't agree with my idea, just close this. 😃