-
Notifications
You must be signed in to change notification settings - Fork 908
Fixes #321 by adding honeypot spam prevention #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary steps in the readme by including honeypot spam prevention by default in the script. Works just fine if no honeypot field is present, since the falsey or empty behavior also means the form is submitted. This just makes it easier for users to take our example and get this feature for free rather than needing to go through steps and having commented out code in our sample script. Also fixes a bug since filtering out the honeypot meant that the honeypot data was no longer being used and was thus broken.
nelsonic
nelsonic
approved these changes
May 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good plan. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary steps in the readme by including
honeypot spam prevention by default in the script.
Works just fine if no honeypot field is present, since
the falsey or empty behavior also means the form is
submitted. This just makes it easier for users to take
our example and get this feature for free rather than
needing to go through steps and having commented
out code in our sample script. Also fixes a bug since
filtering out the honeypot meant that the honeypot
data was no longer being used and was thus broken.