Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Version-Two #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mckennapsean merged 4 commits into master from version-two
Feb 12, 2017
Merged

Version-Two #23

mckennapsean merged 4 commits into master from version-two
Feb 12, 2017

Conversation

@nelsonic
Copy link
Member

@nelsonic nelsonic commented Feb 12, 2016 •
edited
Loading

@nelsonic nelsonic self-assigned this Feb 12, 2016
@nelsonic nelsonic removed their assignment Aug 15, 2016
Copy link
Collaborator

@nelsonic - Did you want this PR merged to address #22 ?

FYI, looks like the current version of Hapi is now v16.1.0 - if you want this merged, feel free to update the version or not and I can check it out / test it!

Copy link
Member Author

@mckennapsean thanks for reminding me! 👍
I've now removed Hapi and substituted it for live-server see: #80
this PR can be reviewed/merged. thanks again! 🚀
mckennapsean reacted with hooray emoji

Copy link
Member Author

@mckennapsean thanks for fixing typos. 👍 📝
mckennapsean reacted with thumbs up emoji

Copy link
Collaborator

@mckennapsean mckennapsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes will improve the tutorial by better explaining the node.js elements and providing a method for folks to test out the file locally via a simple web-server. Overall, a great addition, thanks @nelsonic !

@mckennapsean mckennapsean merged commit 5c6af92 into master Feb 12, 2017
@nelsonic nelsonic deleted the version-two branch February 12, 2017 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mckennapsean mckennapsean mckennapsean approved these changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update version of Hapi in devDependencies

AltStyle によって変換されたページ (->オリジナル) /