Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

drop python<=3.7 support and use of six #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kloczek wants to merge 2 commits into dropbox:main
base: main
Choose a base branch
Loading
from kloczek:main
Open

Conversation

@kloczek
Copy link

@kloczek kloczek commented Jun 3, 2024

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • SDK Code Change
  • Example/Test Code Change

Validation

  • Does tox pass?
  • Do the tests pass?

Pytest passes with this PR

sr/lib/python3.10/site-packages
+ /usr/bin/pytest -ra -m 'not network' --ignore test/integration/test_dropbox.py
==================================================================================== test session starts ====================================================================================
platform linux -- Python 3.10.14, pytest-8.2.1, pluggy-1.5.0
rootdir: /home/tkloczko/rpmbuild/BUILD/dropbox-sdk-python-12.0.1
configfile: setup.cfg
plugins: hypothesis-6.100.0, mock-3.14.0
collected 35 items
test/unit/test_dropbox_unit.py ................................... [100%]
==================================================================================== 35 passed in 1.05s =====================================================================================

kloczek added 2 commits June 3, 2024 14:26 
Filter all code over `pyupgrade --py38-plus`.
Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
With changes generated by `pyupgrade` now it is easier to remove
use `six`.
Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Author

kloczek commented Jun 3, 2024

Python 3.7 is EOSED almost year now.
In Oct this year 3.8 will be EOSed as well.

Copy link
Contributor

greg-db commented Jun 3, 2024

Thanks for submitting this! I'll ask the team to review this.
kloczek reacted with thumbs up emoji

Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the intent of the PR

kloczek reacted with thumbs up emoji kloczek reacted with eyes emoji
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@auvipy auvipy auvipy left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /