Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Restore automatic spec updates #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
maxbelanger wants to merge 8 commits into main
base: main
Choose a base branch
Loading
from dbx-max-fix-spec
Draft

Restore automatic spec updates #494

maxbelanger wants to merge 8 commits into main from dbx-max-fix-spec

Conversation

@maxbelanger
Copy link
Contributor

@maxbelanger maxbelanger commented May 9, 2024
edited
Loading

This was broken due to an issue with the token used to create the PR. This changes the workflow to use the GITHUB_TOKEN provided to the action instead, but we have to disable the formal request for review made to the sdk-maintainers group for now.

Copy link

codecov bot commented May 9, 2024
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.26%. Comparing base (41e4b00) to head (f691206).

Additional details and impacted files
@@ Coverage Diff @@
## main #494 +/- ##
=======================================
 Coverage 64.26% 64.26% 
=======================================
 Files 31 31 
 Lines 52606 52606 
 Branches 3841 3841 
=======================================
 Hits 33808 33808 
 Misses 18638 18638 
 Partials 160 160 
Flag Coverage Δ
integration 64.17% <ø> (ø)
unit 63.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxbelanger maxbelanger marked this pull request as ready for review May 10, 2024 00:50
@maxbelanger maxbelanger marked this pull request as draft May 10, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sderickson sderickson Awaiting requested review from sderickson

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /