-
Notifications
You must be signed in to change notification settings - Fork 330
Extend test matrix up to 3.12 #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA assistant check
All committers have signed the CLA.
Thanks for putting this together! I'll ask the team to review this.
hugovk
commented
Nov 18, 2023
Does this fail on 3.12 with #483?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 36 in f40e73f
I think something like 'setuptools; python_version>="3.12"' should be added to the setup_requires list.
Without this I can't create a virtual env for this library on Python 3.12
@hugovk It did not fail on 3.12 for the CI: https://github.com/foarsitter/dropbox-sdk-python/actions/runs/6707504248
@hugovk It did not fail on 3.12 for the CI: https://github.com/foarsitter/dropbox-sdk-python/actions/runs/6707504248
@foarsitter this is because requirements.txt also includes some requirements for development including sphinx which installs setuptools. Ref raw logs of the action:
2023年10月31日T13:53:47.3735410Z Collecting setuptools (from babel>=2.9->sphinx->-r requirements.txt (line 9))
I think the packages in the requirements.txt under # Other dependencies for development should be in their own requirements file and not installed in the CI (sphinx for example is explicitly installed in the docs ci step anyway).
If you remove sphinx from requirements.txt, I think that the Python 3.12 ci will fail.
I believe #484 (comment) is needed. I can't activate a virtual environment here on Python 3.12 without this change.
f40e73f to
c4bc007
Compare
c4bc007 to
3c5c342
Compare
@sarahboyce do you think it is sufficient to not pin setuptools and let pip decide? Thanks for pointing out that sphinx was installing setuptools in this case.
I added an issue to move to pyproject.toml: #487
@sarahboyce
sarahboyce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@foarsitter this is great! 🌟
Good idea to raise a separate issue around the setup, this PR achieves what we need 👍
Uh oh!
There was an error while loading. Please reload this page.
In the same vein as #481, this PR updates the test matrix & classifiers up to the most recent 3.12.
Checklist
General Contributing
Is This a Code Change?
Validation
toxpass?