-
Couldn't load subscription status.
- Fork 13
Initial updates to add tests that cause the failure #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've had to bite the bullet here and look to add a defaultValue to the Form component (which arguably I should have done originally). This will mean that using the Form component with a value rather than a defaultValue will mean that it will have to be fully controlled (e.g. changes captured and passed back as the new value) but this is probably a better pattern anyway.
Unfortunately I still have one unit test failing following my latest changes. Apologies this is taking so long to resolve.
This is a work in progress PR to start addressing #47 .... I've added a test to reproduce the problem but haven't been able to add a solution yet that doesn't break other tests. I'll continue to investigate and try to get a good solution that doesn't require breaking changes.