@ramanathanv Is this PR ready to review? I see some StringIndexerTests tests failing in the pipeline.

@ramanathanv Is this PR ready to review? I see some StringIndexerTests tests failing in the pipeline.

Hi @Niharikadutta ,

In the test case, I am trying to compare two List objects using Assert.Equal(). I notice in the test results that the Lists have the same content (see image below). Still there is an error.
image

I assume that there must be a different way to compare the Lists. Can you please suggest me a way an alternate way to do this comparison?

Thanks.

I notice in the test results that the Lists have the same content (see image below).

I see "..." in the output. Can you compare elements one by one to see where the difference comes from?

I notice in the test results that the Lists have the same content (see image below).

I see "..." in the output. Can you compare elements one by one to see where the difference comes from?

Hi @imback82 ,
I noticed that even the raw log file provides only 3 dots "...". Is there another way for me to check this?

What I meant was if you are comparing two lists, you can compare elements in those lists one by one instead of comparing them at the list level. Does it make sense?

In StringIndexer there are a few calls which are missing the get* at the beginning - if I change them all to get* then the test passes for me.

public string GetStringOrderType() => (string)_jvmObject.Invoke("stringOrderType");

should be

public string GetStringOrderType() => (string)_jvmObject.Invoke("getStringOrderType");

public string[] GetInputCols() => (string[])_jvmObject.Invoke("inputCols");

should be

public string[] GetInputCols() => (string[])_jvmObject.Invoke("getInputCols");

public string GetInputCol() => (string)_jvmObject.Invoke("inputCol");

should be

public string GetInputCol() => (string)_jvmObject.Invoke("getInputCol");

public string GetHandleInvalid() => (string)_jvmObject.Invoke("handleInvalid");

should be

public string GetHandleInvalid() => (string)_jvmObject.Invoke("getHandleInvalid");

If you change those then the tests should pass :)

If you change those then the tests should pass :)

Thanks @GoEddie for identifying the issue . I have fixed the property names. But the test fails for unknown reasons. Can you please re-initiate the build/tests?