-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Fix ASP0016 false positive for nested anonymous functions #64174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greetings human! You've submitted a PR that modifies code that is shared with https://github.com/dotnet/runtime . Please make sure you synchronize this code with the changes in that repo!
@dotnet-policy-service
dotnet-policy-service
bot
added
the
Attention: Shared Code Modified
label
Oct 27, 2025
Co-authored-by: halter73 <54385+halter73@users.noreply.github.com>
Copilot
AI
changed the title
(削除) [WIP] Add test for nested anonymous methods in RequestDelegateReturnTypeAnalyzerTests (削除ここまで)
(追記) Fix ASP0016 false positive for nested anonymous functions (追記ここまで)
Oct 27, 2025
Copilot finished work on behalf of
halter73
October 27, 2025 23:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
The ASP0016 analyzer incorrectly flagged
Task<T>returns from nested anonymous functions as returns from the parent RequestDelegate. This caused false positives when lambdas returningTask<T>were passed to methods likeAssert.ThrowsAsync:Changes
IsReturnFromNestedAnonymousFunctionhelper that walks the parent chain to detect returns from nested anonymous functionsThe fix uses
ReferenceEqualsto distinguish between the target RequestDelegate and any nested anonymous functions in its body, ensuring only direct returns from the RequestDelegate are analyzed.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.