Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix design-time services documentation for EF Core 6.0+ #5119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndriySvyryd merged 7 commits into live from copilot/fix-e3a16b11-563b-4bae-a353-a3719b2932c3
Oct 3, 2025

Conversation

Copy link
Contributor

Copilot AI commented Sep 26, 2025
edited by AndriySvyryd
Loading

Summary of Changes

This PR fixes outdated design-time services documentation for EF Core 6.0+ (issues #3390 and #4013).

Files Modified

1. samples/core/Miscellaneous/CommandLine/CustomTools.cs

  • Added provider-specific design-time services registration (required for EF Core 6.0+)
  • Added missing using System; for Activator class
  • Changed from UseSqlServer to UseSqlite to match project dependencies
  • Updated service registration order: DbContext services → provider services → core design-time services

2. entity-framework/core/cli/services.md

  • Updated service list from 10 to 23+ services (added ICandidateNamingService, ICSharpMigrationOperationGenerator, ICompiledModelCodeGenerator, IPrecompiledQueryCodeGenerator, etc.)
  • Updated PackageReference example from version 3.1.9 to 9.0.0
  • Updated ms.date to 01/17/2025

3. entity-framework/core/performance/advanced-performance-topics.md

  • Added new subsection "Handling compilation errors due to ambiguous type references"
  • Documented how to override CSharpHelper.ShouldUseFullName to return true
  • Added cross-reference link to design-time services documentation

4. entity-framework/core/miscellaneous/internals/tools.md

  • Fixed grammar: "path" → "paths"

Fixes #4013
Fixes #3390

Original prompt

Fix @dotnet/EntityFramework.Docs/issues/3390 and @dotnet/EntityFramework.Docs/issues/4013 by updating the documentation for design services. Read all the comments to make sure you have enough context. Also, examine the implementation of @dotnet/efcore/files/src/EFCore.Design/Design/Internal/DesignTimeServicesBuilder.cs


💬 Share your feedback on Copilot coding agent for the chance to win a 200ドル gift card! Click here to start the survey.

Copilot AI and others added 2 commits September 26, 2025 20:27
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
... validate samples
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot AI changed the title (削除) Fix @dotnet/EntityFramework.Docs/issues/3390 and @dotnet/EntityFramework.Docs/issues/4013 by updating the documentation for design services. Read all the comments to make sure you have enough context. Also, examine the implementation of @dotnet/efcore/... (削除ここまで) (追記) Fix design-time services documentation for EF Core 6.0+ (追記ここまで) Sep 26, 2025
Copilot AI requested a review from AndriySvyryd September 26, 2025 20:32
Copilot finished work on behalf of AndriySvyryd September 26, 2025 20:32
...ion, add provider services
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot AI requested a review from AndriySvyryd October 1, 2025 00:33
Copilot finished work on behalf of AndriySvyryd October 1, 2025 00:33
Copy link
Member

@copilot Add a note to the compiled model docs that CSharpHelper.ShouldUseFullName can be overridden to return true to avoid compilation errors due to ambiguous references. And link to core/cli/services on how to do it

Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Oct 1, 2025

@copilot Add a note to the compiled model docs that CSharpHelper.ShouldUseFullName can be overridden to return true to avoid compilation errors due to ambiguous references. And link to `core/cli/s...

Added documentation in commit ab5b232:

  1. In compiled models documentation (advanced-performance-topics.md): Added a new section "Handling compilation errors due to ambiguous type references" that explains the issue and links to the design-time services documentation.

  2. In design-time services documentation (services.md): Added a "Customizing individual services" section with a complete example showing how to override CSharpHelper.ShouldUseFullName to return true to always use fully-qualified type names.

Both documents now cross-reference each other to provide users with the information they need to resolve ambiguous type reference compilation errors.

Copilot finished work on behalf of AndriySvyryd October 1, 2025 00:42
Copilot AI requested a review from AndriySvyryd October 1, 2025 00:42
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot finished work on behalf of AndriySvyryd October 1, 2025 00:45
Copy link
Member

@copilot Update progress by creating a summary of all changes in this PR

Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot AI requested a review from AndriySvyryd October 1, 2025 00:50
Copilot finished work on behalf of AndriySvyryd October 1, 2025 00:50
Copy link
Contributor Author

Copilot AI commented Oct 1, 2025

@copilot Update progress by creating a summary of all changes in this PR

Summary of Changes

This PR fixes outdated design-time services documentation for EF Core 6.0+ (issues #3390 and #4013).

Files Modified (4 files, +50/-9 lines)

1. samples/core/Miscellaneous/CommandLine/CustomTools.cs

  • Added provider-specific design-time services registration (required for EF Core 6.0+)
  • Added missing using System; for Activator class
  • Changed from UseSqlServer to UseSqlite to match project dependencies
  • Updated service registration order: DbContext services → provider services → core design-time services

2. entity-framework/core/cli/services.md

  • Updated service list from 10 to 23+ services (added ICandidateNamingService, ICSharpMigrationOperationGenerator, ICompiledModelCodeGenerator, IPrecompiledQueryCodeGenerator, etc.)
  • Updated PackageReference example from version 3.1.9 to 9.0.0
  • Updated ms.date to 01/17/2025

3. entity-framework/core/performance/advanced-performance-topics.md

  • Added new subsection "Handling compilation errors due to ambiguous type references"
  • Documented how to override CSharpHelper.ShouldUseFullName to return true
  • Added cross-reference link to design-time services documentation

4. entity-framework/core/miscellaneous/internals/tools.md

  • Fixed grammar: "path" → "paths"

Key Fixes

Copilot finished work on behalf of AndriySvyryd October 1, 2025 00:52
@AndriySvyryd AndriySvyryd requested a review from a team October 1, 2025 01:11
@AndriySvyryd AndriySvyryd marked this pull request as ready for review October 1, 2025 01:11
@AndriySvyryd AndriySvyryd merged commit 5298667 into live Oct 3, 2025
9 checks passed
@AndriySvyryd AndriySvyryd deleted the copilot/fix-e3a16b11-563b-4bae-a353-a3719b2932c3 branch October 3, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roji roji roji approved these changes

@AndriySvyryd AndriySvyryd Awaiting requested review from AndriySvyryd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Design-time services documentation out of date Update Design-time services

AltStyle によって変換されたページ (->オリジナル) /